Skip to content

Remove equatable requirement when using Spy.wasMostRecentlyCalled(matching:) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Remove equatable requirement when using Spy.wasMostRecentlyCalled(matching:) #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Fakes/Spy/Spy+Testing.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ extension Spy {
}

/// Returns whether the most recent call to the spy matches the given closure.
public func wasMostRecentlyCalled(matching matcher: (Arguments) -> Bool) -> Bool where Arguments: Equatable {
public func wasMostRecentlyCalled(matching matcher: (Arguments) -> Bool) -> Bool {
guard let lastCall = calls.last else { return false }
return matcher(lastCall)
}
Expand Down
39 changes: 38 additions & 1 deletion Tests/FakesTests/SpyTests+TestHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,29 @@ struct SpyTestHelpersTest {

@Test func wasCalledWithArguments() {
let spy = Spy<Int, Void>()
let otherSpy = Spy<ANonEquatable, Void>()

spy(3)
otherSpy(ANonEquatable(value: 3))
#expect(spy.wasCalled(with: 3))
#expect(spy.wasCalled(with: 2) == false)

#expect(spy.wasCalled(matching: { $0 == 3 }))
#expect(spy.wasCalled(matching: { $0 == 2 }) == false)

#expect(otherSpy.wasCalled(matching: { $0.value == 3 }))
#expect(otherSpy.wasCalled(matching: { $0.value == 2 }) == false)

spy(4)
otherSpy(ANonEquatable(value: 4))
#expect(spy.wasCalled(with: 3))
#expect(spy.wasCalled(matching: { $0 == 3 }))

#expect(spy.wasCalled(with: 4))
#expect(spy.wasCalled(matching: { $0 == 4 }))

#expect(otherSpy.wasCalled(matching: { $0.value == 4 }))
#expect(otherSpy.wasCalled(matching: { $0.value == 3 }))
}

@Test func wasCalledWithTimes() {
Expand All @@ -56,16 +65,19 @@ struct SpyTestHelpersTest {

@Test func wasCalledWithMultipleArgumentsAndTimes() {
let spy = Spy<Int, Void>()
let otherSpy = Spy<ANonEquatable, Void>()

spy(1)
otherSpy(ANonEquatable(value: 1))
spy(3)
otherSpy(ANonEquatable(value: 3))

#expect(spy.wasCalled(with: [1, 3]))
#expect(spy.wasCalled(with: [3, 1]) == false) // order matters

#expect(spy.wasCalled(
matching: [
{ $0 == 1},
{ $0 == 1 },
{ $0 == 3 }
]
))
Expand All @@ -75,24 +87,49 @@ struct SpyTestHelpersTest {
{ $0 == 1 }
]
) == false)

#expect(otherSpy.wasCalled(
matching: [
{ $0.value == 1 },
{ $0.value == 3 }
]
))
#expect(otherSpy.wasCalled(
matching: [
{ $0.value == 3 },
{ $0.value == 1 }
]
) == false)
}

@Test func testMostRecentlyBeCalled() {
let spy = Spy<Int, Void>()
let otherSpy = Spy<ANonEquatable, Void>()

spy(1)
otherSpy(ANonEquatable(value: 1))
#expect(spy.wasMostRecentlyCalled(with: 1))
#expect(spy.wasMostRecentlyCalled(with: 2) == false)

#expect(spy.wasMostRecentlyCalled(matching: { $0 == 1}))
#expect(spy.wasMostRecentlyCalled(matching: { $0 == 2}) == false)

#expect(otherSpy.wasMostRecentlyCalled(matching: { $0.value == 1}))
#expect(otherSpy.wasMostRecentlyCalled(matching: { $0.value == 2}) == false)

spy(2)
otherSpy(ANonEquatable(value: 2))
#expect(spy.wasMostRecentlyCalled(with: 1) == false)
#expect(spy.wasMostRecentlyCalled(with: 2))

#expect(spy.wasMostRecentlyCalled(matching: { $0 == 1}) == false)
#expect(spy.wasMostRecentlyCalled(matching: { $0 == 2}))

#expect(otherSpy.wasMostRecentlyCalled(matching: { $0.value == 1}) == false)
#expect(otherSpy.wasMostRecentlyCalled(matching: { $0.value == 2}))
}
}

struct ANonEquatable {
let value: Int
}
Loading