-
-
Notifications
You must be signed in to change notification settings - Fork 32
Improve selection highlighting #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
supersaiyansubtlety
wants to merge
125
commits into
QuiltMC:develop/2.7
Choose a base branch
from
supersaiyansubtlety:improve-selection-highlighting
base: develop/2.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve selection highlighting #318
supersaiyansubtlety
wants to merge
125
commits into
QuiltMC:develop/2.7
from
supersaiyansubtlety:improve-selection-highlighting
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and timers, respectively
…t's the same class (editor bounds were 0x0 when setting source) navigate to tooltip target entry declaration when showing tooltip
stop excluding curly braces from method and class sources
add "No source available" label when there's no classhandle
centralize target name reporting
refine error messages
add local source trimming
… showing parent method
…stead of assuming offset
add/remove EntryTooltip's global listeners on open/close reset TooltipManager on key presses
d4aa871 to
7f4b9ee
Compare
7f4b9ee to
c6b5e8f
Compare
c6b5e8f to
1e14e74
Compare
1e14e74 to
7161b54
Compare
use new installation methods for LineNumbersRuler and PairsMarker
…for multiline snippets
7161b54 to
ed8f3a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #317
Makes several improvements to the blinking outline that indicates which entry has been navigated to:
Before
selection-highlighter-before.mp4
After
selection-highlighter-after.mp4
Custom
selection-highlighter-custom.mp4