Downstream Fabric Loader 0.19.3 - #498
Merged
Merged
Conversation
MrCat12-Studios
marked this pull request as draft
July 18, 2026 08:30
MrCat12-Studios
marked this pull request as ready for review
July 18, 2026 20:37
Contributor
|
Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried my best to downstream the newest fabric loader version. It was relatively small so it didn't take me that many days. I couldn't find any equivalent of fabric-loader/master:src/test/resources/fabric.mod.json with the same tests so I didn't add the tests from fabric's 748f63b. Until last week the file hadn't been updated since 2021 so I am pretty sure there is a reason why they don't exist. I also couldn't find how to implement the changes in fabric-loader/master:src/main/java/net/fabricmc/loader/impl/FabricLoaderImpl.java from a16c6d6. If anyone could help with that I would be very happy.