Remove the deprecated GUI package in the Plugin API and use the GUI API instead - #499
Open
MrCat12-Studios wants to merge 2 commits into
Open
Remove the deprecated GUI package in the Plugin API and use the GUI API instead#499MrCat12-Studios wants to merge 2 commits into
MrCat12-Studios wants to merge 2 commits into
Conversation
Contributor
Author
|
On my computer it built just fine... |
Contributor
Author
|
Great now it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have removed completely all uses of the deprecated ...api.plugin.gui and replaced it with it's counterparts in ...api.gui while also adding removing or adapting methods from other classes' exported APIs. Regardless of the PR's ability to be merged, you should keep in mind that removing such largely used API ought to be avoided for minimal updates, and should be kept for a major release. However considering the incredibly small to non-existant amount of quilt mods that do use this API even if they shouldn't it'll probably be fine. Lastly note that maintainers are always free to edit.