Skip to content

Fire the hashchange event even if the navigation changes only location.hash #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
genki wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fire the hashchange event even if the navigation changes only location.hash #7329

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd3804c
Fire the hashchange event if the navigation is changing only location…
genki Feb 10, 2025
255e5c4
Try to fix the test failure
genki Feb 10, 2025
e2dd128
Try to fix the test failure
genki Feb 10, 2025
c9054a8
Merge branch 'main' into fire_hashchange
gioboa Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/qwik-city/src/runtime/src/qwik-city-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,14 @@ export const QwikCityProvider = component$<QwikCityProps>((props) => {
if (isBrowser) {
// Use `location.href` because the lastDest signal is only updated on page navigates.
if (type === 'link' && dest.href !== location.href) {
history.pushState(null, '', dest);
if (location.href.startsWith(dest.href.split('#')[0])) {
location.hash = dest.hash;
if (location.hash === '') {
history.pushState(null, '', dest);
}
} else {
history.pushState(null, '', dest);
}
}

// Always scroll on same-page popstates, #hash clicks, or links.
Expand Down
Loading