Skip to content

fix: RequestEventAction has missed a type resolveValue #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Feb 25, 2025

What is it?

fixes #7377

if routeAction$ wants to use resolveValue function,routeLoader$ has be loaded first,
so I move the routerLoader logic before method === 'POST', However, in some situations, it has to remain in its original position.

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner February 25, 2025 05:09
Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: b1cb828

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
@builder.io/qwik Patch
eslint-plugin-qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 requested review from a team as code owners February 25, 2025 06:03
Copy link

pkg-pr-new bot commented Feb 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7378
npm i https://pkg.pr.new/@builder.io/qwik-city@7378
npm i https://pkg.pr.new/eslint-plugin-qwik@7378
npm i https://pkg.pr.new/create-qwik@7378

commit: dda7bf3

Copy link
Contributor

github-actions bot commented Feb 25, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b1cb828

@wmertens
Copy link
Member

the problem is that the resolveValue is not actually working even though it's documented. So this PR needs to implement it too.

@JerryWu1234
Copy link
Contributor Author

JerryWu1234 commented Mar 1, 2025

the problem is that the resolveValue is not actually working even though it's documented. So this PR needs to implement it too.

@wmertens
Is there a code reference I could follow ?

@wmertens
Copy link
Member

wmertens commented Mar 1, 2025

@JerryWu1234 best to search the code for resolveValue and see how it is implemented, and then try to implement it in the same way in the other locations.

@JerryWu1234 JerryWu1234 marked this pull request as draft March 2, 2025 12:54
@JerryWu1234 JerryWu1234 self-assigned this Mar 11, 2025
@JerryWu1234 JerryWu1234 marked this pull request as ready for review March 11, 2025 06:08
@JerryWu1234
Copy link
Contributor Author

@JerryWu1234 best to search the code for resolveValue and see how it is implemented, and then try to implement it in the same way in the other locations.

thanks for your tips, it's useful

@shairez shairez moved this from Backlog to Waiting For Review in Qwik Development Mar 11, 2025
@shairez shairez moved this from Waiting For Review to In progress in Qwik Development Mar 11, 2025
@JerryWu1234 JerryWu1234 marked this pull request as draft March 12, 2025 09:48
@JerryWu1234 JerryWu1234 marked this pull request as ready for review March 13, 2025 03:26
@JerryWu1234 JerryWu1234 moved this from In progress to Waiting For Review in Qwik Development Apr 11, 2025
@JerryWu1234
Copy link
Contributor Author

@wmertens @Varixo please help to review it when you are available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

[🐞] "resolveValue" Function Is Missing in TypeScript Types and Fails in "routeAction$" / "globalAction$"
2 participants