Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated event$ #7407

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

sreeisalso
Copy link
Contributor

@sreeisalso sreeisalso commented Mar 10, 2025

What is it?

  • Feature / enhancement

Description

deprecated event$ #4452

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: c5002d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 10, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7407
npm i https://pkg.pr.new/@builder.io/qwik-city@7407
npm i https://pkg.pr.new/eslint-plugin-qwik@7407
npm i https://pkg.pr.new/create-qwik@7407

commit: c5002d8

Copy link
Contributor

github-actions bot commented Mar 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c5002d8

@sreeisalso sreeisalso marked this pull request as ready for review March 10, 2025 07:59
@sreeisalso sreeisalso requested review from a team as code owners March 10, 2025 07:59
@wmertens
Copy link
Member

Could you also add a changeset?

@sreeisalso
Copy link
Contributor Author

Could you also add a changeset?

@wmertens done

@maiieul
Copy link
Contributor

maiieul commented Mar 11, 2025

@PatrickJS I remember you guys are using it in production. Are you fine with deprecating it for now? We don't have to remove it but that kind of dissuades other developers from using it until we figure out whether we should remove it or replace it with something else.

@sreeisalso sreeisalso requested a review from wmertens March 20, 2025 14:39
@shairez
Copy link
Contributor

shairez commented Mar 25, 2025

Thanks @sreeisalso !

Currently blocked by #6871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

4 participants