docs(cookbook): update class handling #7411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resulted in unexpected behavior when `props.class` was an array.
Updated to:
`class={[props.class, isActive && activeClass ? activeClass : ""]}`
ensuring proper class concatenation and maintaining Tailwind's expected behavior.
This fixes styling inconsistencies and improves component reliability.
🦋 Changeset detectedLatest commit: a997de4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maiieul
reviewed
Mar 11, 2025
| @@ -51,7 +51,7 @@ export const NavLink = component$( | |||
| return ( | |||
| <Link | |||
| {...props} | |||
| class={`${props.class || ''} ${isActive && activeClass ? activeClass : ''}`} | |||
| class={[props.class, isActive && activeClass ? activeClass : ""]} | |||
maiieul
requested changes
Mar 11, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "qwik-docs": patch | |||
There was a problem hiding this comment.
No need for a changeset for docs changes. Can you remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current code results in unexpected behavior when
props.classwas an array. Updated to:class={[props.class, isActive && activeClass ? activeClass : ""]}ensuring proper class concatenation and maintaining Tailwind's expected behavior.
This fixes styling inconsistencies and improves component reliability.