Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a resource a type error when using async _resolved function #7426

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Mar 15, 2025

What is it?

fixes: #7086

follow version 2 to fix this ts error

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners March 15, 2025 03:34
Copy link

changeset-bot bot commented Mar 15, 2025

🦋 Changeset detected

Latest commit: 9451aad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 marked this pull request as draft March 15, 2025 03:42
@JerryWu1234 JerryWu1234 marked this pull request as ready for review March 15, 2025 06:44
Copy link

pkg-pr-new bot commented Mar 15, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7426
npm i https://pkg.pr.new/@builder.io/qwik-city@7426
npm i https://pkg.pr.new/eslint-plugin-qwik@7426
npm i https://pkg.pr.new/create-qwik@7426

commit: 9451aad

Copy link
Contributor

github-actions bot commented Mar 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 9451aad

@JerryWu1234 JerryWu1234 self-assigned this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

[🐞] onResolved cannot return a Promise
1 participant