Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reexecute component with null key #7456

Merged
merged 2 commits into from
Mar 29, 2025
Merged

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Mar 25, 2025

  • reexecute component without any key (or key = null). This is a case where you use some component directly in mdx
  • correctly compare component with null key and fragment with null key

@Varixo Varixo self-assigned this Mar 25, 2025
@Varixo Varixo requested a review from a team as a code owner March 25, 2025 20:24
Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: fa31110

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 25, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7456
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7456
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7456
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7456

commit: fa31110

Copy link
Contributor

github-actions bot commented Mar 25, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview fa31110

@Varixo Varixo marked this pull request as draft March 26, 2025 06:38
@Varixo Varixo force-pushed the v2-null-key-component branch from 2462908 to 13fec50 Compare March 26, 2025 14:49
@Varixo Varixo marked this pull request as ready for review March 29, 2025 14:47
@Varixo Varixo merged commit cb4934b into build/v2 Mar 29, 2025
19 checks passed
@Varixo Varixo deleted the v2-null-key-component branch March 29, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant