-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feature/self hosters deployment #7458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/self hosters deployment #7458
Conversation
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! But some comments
packages/docs/src/routes/docs/deployments/self-hosting/index.mdx
Outdated
Show resolved
Hide resolved
<PackageManagerTabs> | ||
<span q:slot="pnpm"> | ||
```shell | ||
pnpm run qwik add express |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all these commands should just be replaced with a single npx qwik add express
} | ||
|
||
# Cache settings for immutable assets | ||
location /build/ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs /assets handling here, and nginx also has gzip_static on; brotli_static on;
ProxyPassReverse / http://localhost:3000/ | ||
|
||
# Serve static assets directly | ||
<Directory /path/to/your/app/dist/build> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
- Use logging services like Winston or Pino for structured logs | ||
|
||
3. Consider adding application monitoring with: | ||
- Prometheus + Grafana for self-hosted monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's also netdata which is really nice
packages/docs/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just leave these package.json changes for another PR. Keep only the docs change
@wmertens Had made changes you can review my pr and update ! |
@wmertens I was wondering how other developers are tackling this issue as I had encountered in development and had to figure out other ways to test before pushing my code 😕 |
@@ -3657,7 +3657,7 @@ Options for the prefetch service worker. | |||
</tbody></table> | |||
**Returns:** | |||
|
|||
[JSXNode](#jsxnode)<'script'> | |||
JSXNode<'script'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you run pnpm api.update
again please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wmertens
This gives an error
`,"PS C:\asus irfan\Downloads\Qwik\qwik> pnpm api.update
[email protected] api.update C:\asus irfan\Downloads\Qwik\qwik
tsx --require ./scripts/runBefore.ts scripts/index.ts --tsc --api --dev
🌎 Qwik v1.12.1-dev+e08047e [node v20.19.1, win32/x64]
tsc qwik
packages/qwik/src/optimizer/src/plugins/eslint-plugin.ts:25:9 - error TS2353: Object literal may only specify known properties, and 'root' does not exist in type 'Config | Config[]'.
25 root: true,
~~~~
node_modules/.pnpm/[email protected][email protected]/node_modules/eslint/lib/types/index.d.ts:1966:3
1966 overrideConfig?: Linter.Config | Linter.Config[] | null | undefined;
~~~~~~~~~~~~~~
The expected type comes from property 'overrideConfig' which is declared here on type 'Options'
Found 1 error in packages/qwik/src/optimizer/src/plugins/eslint-plugin.ts:25
❌ Error: Command failed with exit code 2: tsc -p C:\asus irfan\Downloads\Qwik\qwik\packages\qwik\tsconfig.json
at makeError (file:///C:/asus%20irfan/Downloads/Qwik/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/lib/error.js:60:11)
at handlePromise (file:///C:/asus%20irfan/Downloads/Qwik/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/index.js:124:26)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async tscQwik (C:\asus irfan\Downloads\Qwik\qwik\scripts\tsc.ts:8:18)
at async build (C:\asus irfan\Downloads\Qwik\qwik\scripts\build.ts:63:7)
Error: Error: Command failed with exit code 2: tsc -p C:\asus irfan\Downloads\Qwik\qwik\packages\qwik\tsconfig.json
at makeError (file:///C:/asus%20irfan/Downloads/Qwik/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/lib/error.js:60:11)
at handlePromise (file:///C:/asus%20irfan/Downloads/Qwik/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/index.js:124:26)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async tscQwik (C:\asus irfan\Downloads\Qwik\qwik\scripts\tsc.ts:8:18)
at async build (C:\asus irfan\Downloads\Qwik\qwik\scripts\build.ts:63:7)
at panic (C:\asus irfan\Downloads\Qwik\qwik\scripts\util.ts:287:33)
at build (C:\asus irfan\Downloads\Qwik\qwik\scripts\build.ts:192:5)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
ELIFECYCLE Command failed with exit code 1."`
we're fixing the builder content issue, but you can always go directly to /docs |
What is it?
Resolves :- #5412
Description
For a long time this issue was pending and thought of resolving it as per my best.
So I had created a new doc section, where I had mentioned about the following things,
Checklist
pnpm change