Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: temporarily disable Insights until rollup fix of emitFile allow-extension #7462

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Mar 27, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Reasons:

  • Insights's bundling isn't really better than pure Rollup's atm
  • Insights prevents us from easily detecting prefetching issues on the qwik docs, have users report them to us
  • If some piece of code is changed (e.g. algolia search), then insights won't be applied until next build. This can lead to waterfalls on interaction in between two deployments. For example this PR would have a waterfall with insights: feat(docs): expose the search in the small viewport #6966
  • Insight's ordering of chunks isn't being applied apparently, which is the biggest advantage of it. We need to look into this.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner March 27, 2025 19:29
Copy link
Contributor

github-actions bot commented Mar 27, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 9cd2172

gioboa
gioboa previously approved these changes Mar 27, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should leave the insights component in place so it still sends metrics, and disable the plugin only

Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 9cd2172

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maiieul maiieul requested a review from wmertens March 28, 2025 11:12
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reluctantly :)

@wmertens wmertens merged commit 1d89c07 into QwikDev:main Mar 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants