Skip to content

fix: add HTMLElementAttrs and SVGProps types to exports #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: build/v2
Choose a base branch
from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Apr 11, 2025

What is it?

fixes: #7394

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners April 11, 2025 07:17
Copy link

changeset-bot bot commented Apr 11, 2025

🦋 Changeset detected

Latest commit: d549682

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Apr 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7510
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7510
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7510
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7510

commit: b028105

Copy link
Contributor

github-actions bot commented Apr 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b028105

@JerryWu1234
Copy link
Contributor Author

@Varixo done it,

@JerryWu1234 JerryWu1234 self-assigned this Apr 14, 2025
@JerryWu1234 JerryWu1234 requested a review from Varixo April 14, 2025 07:30
@@ -0,0 +1,5 @@
---
'@qwik.dev/core': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Varixo @wmertens technically this is not a patch, it's a minor (we're adding an API surface) no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants