feat(cli): Add check-client command to verify bundle freshness #7517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 449eb30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
JerryWu1234
force-pushed
the
7479_build_serve
branch
from
0856f08 to
b4c6899
Compare
wmertens
requested changes
Apr 18, 2025
|
@wmertens I refactored code, it seems to look much better right now |
wmertens
requested changes
Apr 25, 2025
Move all check-client related functions and constants into a single index.ts file to improve maintainability and reduce file fragmentation
Modify the check-client command to accept `src` and `dist` as arguments instead of hardcoding them. This change enhances flexibility and allows for more dynamic usage of the command across different adapters. The corresponding build scripts in various adapters' `package.json` files have been updated to pass these arguments.
wmertens
requested changes
Apr 28, 2025
Remove redundant log steps and improve error handling in the client check process. This change focuses on reducing noise in the logs and ensuring clearer error messages.
|
@wmertens done |
|
done |
The function name `isNewerThan` was renamed to `hasNewer` to better reflect its purpose of checking if any files in the directory are newer than the given timestamp. This improves code readability and understanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
fixes: #7479
This commit adds a new CLI command that checks if the client bundle is up-to-date by:
Description
Checklist
pnpm change