Skip to content

Conversation

@danielbayley
Copy link
Contributor

@danielbayley danielbayley commented May 1, 2025

What is it?

  • Docs

Description

I found a solution to fix the README SVGs across all of my repos, so thought I would share :)

Fix logo text to display correctly, cross-browser, including a temporary bug fix for WebKit.

Note

I don’t think this warrants a changeset, but FYI, I had trouble with pnpm install refusing to work! (Frequent pnpm user here on macOS…)

Checklist

@danielbayley danielbayley requested a review from a team as a code owner May 1, 2025 14:32
@changeset-bot
Copy link

changeset-bot bot commented May 1, 2025

⚠️ No Changeset found

Latest commit: 340e864

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 340e864

Fix logo text to display correctly, cross-browser, including a temporary [bug](https://bugs.webkit.org/show_bug.cgi?id=199134) fix for WebKit
wmertens
wmertens previously approved these changes May 6, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens added the COMP: docs Improvements or additions to documentation label May 6, 2025
@wmertens wmertens moved this from Backlog to Waiting For Review in Qwik Development May 6, 2025
@danielbayley danielbayley requested a review from a team as a code owner May 6, 2025 13:33
@danielbayley danielbayley requested a review from wmertens May 6, 2025 13:34
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @danielbayley

@shairez shairez merged commit d54c51d into QwikDev:main May 12, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development May 12, 2025
@danielbayley danielbayley deleted the logo branch May 12, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

COMP: docs Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants