Skip to content

removed build warnings due to improper order of default and min #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

sreeisalso
Copy link
Contributor

What is it?

  • Feature / enhancement

Description

removed warnings due to improper order of default and min

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@sreeisalso sreeisalso requested a review from a team as a code owner May 11, 2025 11:00
Copy link

changeset-bot bot commented May 11, 2025

⚠️ No Changeset found

Latest commit: b9343e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented May 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7581
npm i https://pkg.pr.new/@builder.io/qwik-city@7581
npm i https://pkg.pr.new/eslint-plugin-qwik@7581
npm i https://pkg.pr.new/create-qwik@7581

commit: b9343e5

Copy link
Contributor

github-actions bot commented May 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b9343e5

@sreeisalso
Copy link
Contributor Author

@sreeisalso
Copy link
Contributor Author

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the problem is that one of the formatting tools incorrectly orders, but it's not prettier, and we don't have an automated test for it.

LGTM

@wmertens wmertens merged commit b64d65e into QwikDev:main May 11, 2025
19 checks passed
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help 👏

@sreeisalso sreeisalso deleted the remove-warnings branch May 11, 2025 16:59
@sreeisalso sreeisalso restored the remove-warnings branch May 12, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants