Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-virtual-css-dev-ssr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/qwik': patch
---

fix: resolve 404 error for virtual CSS modules during dev SSR
14 changes: 12 additions & 2 deletions packages/qwik/src/optimizer/src/plugins/vite-dev-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export async function configureDevServer(
location: 'head',
attributes: {
rel: 'stylesheet',
href: `${base}${url.slice(1)}`,
href: toDevServerHref(base, url),
},
});
}
Expand Down Expand Up @@ -261,7 +261,7 @@ export async function configureDevServer(
!hasCSSImporter &&
!cssImportedByCSS.has(v.url)
) {
res.write(`<link rel="stylesheet" href="${base}${v.url.slice(1)}">`);
res.write(`<link rel="stylesheet" href="${toDevServerHref(base, v.url)}">`);
added.add(v.url);
}
}
Expand Down Expand Up @@ -438,6 +438,16 @@ function relativeURL(url: string, base: string) {
return url;
}

/** Converts a Vite module graph URL to a dev server href for `<link>` tags. */
export function toDevServerHref(base: string, url: string): string {
if (url.startsWith('/')) {
return `${base}${url.slice(1)}`;
}
// Virtual modules need the /@id/ prefix; strip the \0 Rollup convention prefix
const cleanUrl = url.startsWith('\0') ? url.slice(1) : url;
return `${base}${VALID_ID_PREFIX.slice(1)}${cleanUrl}`;
}

const DEV_QWIK_INSPECTOR = (opts: NormalizedQwikPluginOptions['devTools'], srcDir: string) => {
const qwikdevtools = {
hotKeys: opts.clickToSource ?? [],
Expand Down
48 changes: 48 additions & 0 deletions packages/qwik/src/optimizer/src/plugins/vite-dev-server.unit.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import { describe, expect, test } from 'vitest';
import { toDevServerHref } from './vite-dev-server';

describe('toDevServerHref', () => {
test('normal CSS file with base /', () => {
expect(toDevServerHref('/', '/src/styles.css')).toBe('/src/styles.css');
});

test('normal CSS file with custom base', () => {
expect(toDevServerHref('/my-app/', '/src/styles.css')).toBe('/my-app/src/styles.css');
});

test('normal CSS file with HMR timestamp', () => {
expect(toDevServerHref('/', '/src/styles.css?t=1234567890')).toBe(
'/src/styles.css?t=1234567890'
);
});

test('virtual CSS module with base /', () => {
expect(toDevServerHref('/', 'virtual:my-plugin:foo.css')).toBe(
'/@id/virtual:my-plugin:foo.css'
);
});

test('virtual CSS module with custom base', () => {
expect(toDevServerHref('/my-app/', 'virtual:my-plugin:foo.css')).toBe(
'/my-app/@id/virtual:my-plugin:foo.css'
);
});

test('virtual CSS module with \\0 prefix', () => {
expect(toDevServerHref('/', '\0virtual:my-plugin:foo.css')).toBe(
'/@id/virtual:my-plugin:foo.css'
);
});

test('virtual CSS module with \\0 prefix and custom base', () => {
expect(toDevServerHref('/my-app/', '\0virtual:my-plugin:foo.css')).toBe(
'/my-app/@id/virtual:my-plugin:foo.css'
);
});

test('virtual CSS module with path-like ID', () => {
expect(toDevServerHref('/', 'virtual:my-plugin:/src/routes/index.tsx.css')).toBe(
'/@id/virtual:my-plugin:/src/routes/index.tsx.css'
);
});
});
Loading