fix(ci): change docs size test with e2e#8545
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR replaces the prior docs-size benchmark check (and its stored baselines) with a deterministic router SSG snapshot E2E test, and updates CI/scripts accordingly.
Changes:
- Removed the docs-size validation script + JSON baseline, and dropped the CI step that ran it.
- Added a Playwright E2E test that Vite-builds a dedicated router SSG fixture and compares normalized HTML + state dump against checked-in snapshots (with an update mode).
- Updated root
package.jsonscripts to add dedicated commands for running/updating the new router SSG snapshot test.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/validate-docs-size.ts | Deleted the standalone docs-size benchmark/diagnostic script. |
| scripts/docs-size-results.json | Deleted the stored docs-size baseline results. |
| .github/workflows/ci.yml | Removed the “Docs Size Benchmarks” CI step. |
| package.json | Removed docs-size benchmark scripts; added router SSG snapshot e2e run/update scripts. |
| e2e/qwik-e2e/tests/qwikrouter/ssg-snapshot.e2e.ts | New Playwright test that builds an SSG fixture and asserts normalized HTML/state snapshots. |
| e2e/qwik-e2e/apps/qwikrouter-ssg-snapshot/src/routes/index.tsx | New fixture route designed to produce stable, inspectable serialized state. |
| e2e/qwik-e2e/apps/qwikrouter-ssg-snapshot/src/root.tsx | New fixture root wiring RouterOutlet + canonical URL. |
| e2e/qwik-e2e/apps/qwikrouter-ssg-snapshot/src/entry.ssr.tsx | New SSR entry using createRenderer for the fixture. |
| e2e/qwik-e2e/apps/qwikrouter-ssg-snapshot/package.json | Declares the new fixture app as private ESM module. |
| e2e/qwik-e2e/apps/qwikrouter-ssg-snapshot/expected.ssg.html | Checked-in expected normalized SSG HTML snapshot. |
| e2e/qwik-e2e/apps/qwikrouter-ssg-snapshot/expected.state.txt | Checked-in expected normalized serialized-state dump snapshot. |
| scripts/submodule-core.ts | Removed importMetaFix prepend logic from core build outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This reverts commit 0f50c87.
wmertens
force-pushed
the
fix-docs-size
branch
2 times, most recently
from
e40c3f1 to
522d479
Compare
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.