Fixed the failed test.#4
Merged
Merged
Conversation
P.S. From the provious commit and this one, NO AI USED! Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : modifié : .github/workflows/ci.yml
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate CI workflow to install an additional Python dependency (platformdirs) during test setup to resolve a previously failing test. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of hardcoding
psutil platformdirs pytestin the workflow, consider installing from your existing dependency/requirements configuration (e.g., a dev requirements file or extras) so CI stays in sync with the project's declared dependencies.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of hardcoding `psutil platformdirs pytest` in the workflow, consider installing from your existing dependency/requirements configuration (e.g., a dev requirements file or extras) so CI stays in sync with the project's declared dependencies.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P.S. From the provious commit and this one, NO AI USED!
Sur la branche dev
Votre branche est à jour avec 'origin/dev'.
Modifications qui seront validées :
modifié : .github/workflows/ci.yml
Summary by Sourcery
Build: