Skip to content

Fixed the failed test.#4

Merged
R-Larocque merged 1 commit into
hfrom
dev
May 9, 2026
Merged

Fixed the failed test.#4
R-Larocque merged 1 commit into
hfrom
dev

Conversation

@R-Larocque

@R-Larocque R-Larocque commented May 9, 2026

Copy link
Copy Markdown
Owner

P.S. From the provious commit and this one, NO AI USED!
Sur la branche dev
Votre branche est à jour avec 'origin/dev'.

Modifications qui seront validées :
modifié : .github/workflows/ci.yml

Summary by Sourcery

Build:

  • Add platformdirs to the Python dependencies installed in the CI workflow to fix the failing test environment.

P.S. From the provious commit and this one, NO AI USED!
 Sur la branche dev
 Votre branche est à jour avec 'origin/dev'.

 Modifications qui seront validées :
	modifié :         .github/workflows/ci.yml
@sourcery-ai

sourcery-ai Bot commented May 9, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update CI workflow to install an additional Python dependency (platformdirs) during test setup to resolve a previously failing test.

File-Level Changes

Change Details Files
Ensure CI installs the platformdirs dependency so tests have all required packages available.
  • Extend pip install command in the CI workflow to include the platformdirs package alongside psutil and pytest
  • Keep the rest of the CI workflow (Python setup, package installation, and test execution) unchanged
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@R-Larocque R-Larocque merged commit c223079 into h May 9, 2026
17 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of hardcoding psutil platformdirs pytest in the workflow, consider installing from your existing dependency/requirements configuration (e.g., a dev requirements file or extras) so CI stays in sync with the project's declared dependencies.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of hardcoding `psutil platformdirs pytest` in the workflow, consider installing from your existing dependency/requirements configuration (e.g., a dev requirements file or extras) so CI stays in sync with the project's declared dependencies.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant