Remove ns_startup_args*.txt functionality - #517
Conversation
F1F7Y
added
needs testing
| if (fs::exists("ns_startup_args.txt")) | ||
| { | ||
| std::ofstream file("ns_startup_args.txt"); | ||
| std::string defaultArgs = "-multiple"; |
There was a problem hiding this comment.
This PR means we lose the functionality of these default args right?
If so, this could cause issues with the game complaining about multiple instances if an instance is stuck in the background or something
| if (fs::exists("ns_startup_args_dedi.txt")) | ||
| { | ||
| std::ofstream file("ns_startup_args_dedi.txt"); | ||
| std::string defaultArgs = "+setplaylist private_match"; |
There was a problem hiding this comment.
What is the behaviour for dedis when this functionality is lost?
Also, a number of dedis use ns_startup_args_dedi.txt to set up the server. If this gets merged we should warn server hosters about this no longer being supported
github-actions
Bot
added
the
merge conflicts
|
Merge conflicts atm |
|
Drafted until conflicts are resolved so it's clear which PRs are ready to review atm. Feel free to undraft again at any moment or when you resolved the conflicts. |
3 participants
Removes
ns_startup_args*.txtfunctionality as discussed at #507Main reason for doing this is getting rid of having to hook
GetCommandLineA, which meant some args would only work when passed directly to the exe.