Skip to content

Fix Experimental (Launcher) - #884

Open
ASillyNeko wants to merge 99 commits into
R2Northstar:mainfrom
ASillyNeko:main
Open

Fix Experimental (Launcher)#884
ASillyNeko wants to merge 99 commits into
R2Northstar:mainfrom
ASillyNeko:main

Conversation

@ASillyNeko

@ASillyNeko ASillyNeko commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Dec 27, 2025

@catornot catornot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the no report part. Bots do take up player slots therefore they must be reported in some way otherwise servers could get report as not full when they are in fact full.

@ASillyNeko
ASillyNeko requested a review from catornot December 27, 2025 22:04
Comment thread primedev/dedicated/dedicated.cpp Outdated

@catornot catornot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be probably better to fix #548 instead but this is fine as well

blocking until https://github.com/R2Northstar/NorthstarLauncher/pull/884/changes#r2651637462 is resolved

@ASillyNeko
ASillyNeko requested a review from catornot December 30, 2025 02:46
@catornot
catornot dismissed their stale review December 30, 2025 05:41

the blocking thing got resolved

@pg9182

pg9182 commented Dec 30, 2025

Copy link
Copy Markdown
Member

must be reported in some way

I could add support for reporting the bot count.

@catornot

catornot commented Jan 2, 2026

Copy link
Copy Markdown
Member

I could add support for reporting the bot count.

but that still should be a different pr since it would need prs to multiple repos
(by "that" I mean change that I request to remove)

@ASillyNeko ASillyNeko changed the title Improve support for bots. Improve support for bots, reparse, and loading mods on server/client vm. Jan 11, 2026
@ASillyNeko ASillyNeko changed the title Improve support for bots, reparse, and loading mods on server/client vm. Improve support for bots, reparse, and loading mods on server/client squrriel vm. Jan 11, 2026
@ASpoonPlaysGames

Copy link
Copy Markdown
Contributor

There's like, a LOT going on here. Most of the diff is updating dependencies and that's fine (probably should be a separate PR) but I'm really struggling to see what the actual changes are and what the point of them is

Comment thread Dockerfile
Comment thread primedev/dedicated/dedicated.cpp Outdated
@github-actions github-actions Bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label May 23, 2026
@github-actions github-actions Bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label May 23, 2026
@github-actions github-actions Bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jun 1, 2026
@github-actions github-actions Bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jun 3, 2026
@catornot

catornot commented Aug 8, 2026

Copy link
Copy Markdown
Member

I think we can safely merge a subset of this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

fatal_script_errors_server Doesn't prevent dedicated servers from crashing

8 participants