Hardcode cardinals of all exports in wsock32 - #931
Open
catornot wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
needs testing
catornot
force-pushed
the
fix-wsock32-ordinals
branch
from
August 10, 2026 07:42
e92e113 to
f25d685
Compare
AllusiveWheat
approved these changes
Aug 11, 2026
AllusiveWheat
left a comment
AllusiveWheat
left a comment
Contributor
There was a problem hiding this comment.
it probably works, seems fine
Member
|
this is a bit excessive, the issue is probably only present due to the original .def file having the typo |
|
I don't know what this was supposed to fix, but the WSock proxy (from main, not this PR) caused a hard freeze for me right after the logos, and this fixed it (I downloaded an artifact to test it live in my install). The game now launches properly with that proxy, as opposed to freezing completely with a proxy freshly built from main 👍 I did not test ingame further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the recent regression in the release.
I would not even try to justify such a blunder, but this is also just absurd. either way it seems like certain titanfall 2 dlls on windows care a lot more about ordinals than on linux which is how it seemingly never got caught.
not sure if everything needs to be hardcoded but I tested it on fresh install of windows 10 22H2 where it seems to work with this pr. therefore I will push a new release with this change.