Skip to content

chore: add action-lint#304

Merged
rebel-seinpark merged 5 commits intopre-commit-3-10from
pre-commit-3-10-actionlint
Jan 29, 2026
Merged

chore: add action-lint#304
rebel-seinpark merged 5 commits intopre-commit-3-10from
pre-commit-3-10-actionlint

Conversation

@rebel-seinpark
Copy link
Copy Markdown
Collaborator

@rebel-seinpark rebel-seinpark commented Jan 28, 2026 •
edited
Loading

🚀 Summary of Changes

Add action-lint sync with vllm original repo

What does this PR do? What feature, fix, or improvement does it bring?

📌 Related Issues / Tickets

  • Resolves #
  • Related to #

✅ Type of Change

  • ✨ Feature (feature)
  • 🧠 Model support (model)
  • 🧬 Core engine changes (core)
  • 🛠 Bug fix (bug-fix)
  • ⚙️ Performance improvement (perf)
  • 🔁 Refactor or code cleanup (refactor)
  • 📄 Documentation (docs)
  • ❓ Other (other): please describe

🧪 How to Test

  1. Run ...
  2. Verify output: ...
  3. Edge case tested: ...

📸 Screenshots / Logs (if applicable)

📋 Checklist

  • PR title follows Conventional Commits format
  • This PR is linked to an existing issue
  • The test method is described, and the expected result is clearly stated
  • Relevant documentation has been updated (if applicable)

💬 Notes

rebel-eunji
rebel-eunji reviewed Jan 28, 2026
View reviewed changes
Comment thread .pre-commit-config.yaml Outdated
Comment thread .pre-commit-config.yaml Outdated
# - id: markdownlint
# exclude: '.*\.inc\.md'
# stages: [manual] # Only run in CI
- repo: https://github.com/jackdewinter/pymarkdown
Copy link
Copy Markdown
Collaborator

@rebel-eunji rebel-eunji Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the vllm repo is using markdownlint. Do we still need it?

Copy link
Copy Markdown
Collaborator Author

@rebel-seinpark rebel-seinpark Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly, but what about following the vllm method?

rebel-eunji
rebel-eunji reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rebel-eunji rebel-eunji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove actionlint.yaml in root directory.

@rebel-seinpark
Copy link
Copy Markdown
Collaborator Author

rebel-seinpark commented Jan 28, 2026 •
edited
Loading

Please remove actionlint.yaml in root directory.

why?

@rebel-eunji
Copy link
Copy Markdown
Collaborator

rebel-eunji commented Jan 28, 2026

Because I've already create actionlint.yaml in root directory, but you've created it in .github.
So I think this PR removes unused actionlint.yaml in the root directory.

@rebel-seinpark
Copy link
Copy Markdown
Collaborator Author

rebel-seinpark commented Jan 29, 2026

Because I've already create actionlint.yaml in root directory, but you've created it in .github. So I think this PR removes unused actionlint.yaml in the root directory.

I believe .github/actionlint.yaml is the correct location, not the root directory. In reference, actionlint searches for config files in this path: .github/actionlint.yml

@rebel-seinpark rebel-seinpark merged commit f7fe1db into pre-commit-3-10 Jan 29, 2026
1 of 2 checks passed
@rebel-seinpark rebel-seinpark deleted the pre-commit-3-10-actionlint branch January 29, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebel-eunji rebel-eunji rebel-eunji approved these changes

@rebel-jswoo rebel-jswoo Awaiting requested review from rebel-jswoo

@rebel-sunwook rebel-sunwook Awaiting requested review from rebel-sunwook

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rebel-seinpark @rebel-eunji