update: support data parallel without expert parallel#376
Open
rebel-wonsubkim wants to merge 8 commits intodev-0.12-rebasefrom
Open
update: support data parallel without expert parallel#376rebel-wonsubkim wants to merge 8 commits intodev-0.12-rebasefrom
rebel-wonsubkim wants to merge 8 commits intodev-0.12-rebasefrom
Conversation
+ DO NOT flatten tp across dp if expert_parallel is disabled in RBLN Signed-off-by: wonsub kim <subang0@rebellions.ai>
Signed-off-by: wonsub kim <subang0@rebellions.ai>
rebel-wonsubkim
requested review from
rebel-jaehwang,
rebel-jiwoopark and
rebel-ykchoi
Signed-off-by: wonsub kim <subang0@rebellions.ai>
| """ | ||
| dp_size = self.vllm_config.parallel_config.data_parallel_size | ||
| dp_size = self.vllm_config.parallel_config.data_parallel_size \ | ||
| and self.vllm_config.parallel_config.enable_expert_parallel |
Contributor
There was a problem hiding this comment.
I think it needs to be fixed like below.
dp_ep_enable = self.vllm_config.parallel_config.data_parallel_size > 1
and self.vllm_config.parallel_config.enable_expert_parallel
dp_size > 1 --> dp_ep_enable
- add ManualBucketingManager
- builds decode buckets from a user-provided bucket list
- add rbln_envs
- add "manual" to VLLM_RBLN_DECODE_BATCH_BUCKET_STRATEGY options
- add VLLM_RBLN_DECODE_BATCH_BUCKET_MANUAL_BUCKETS env var
- comma-separated integers
This reverts commit 5c0b095.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.