fix: consider kv cache 64 align to estimate kv cache memory size#417
Open
rebel-wonsubkim wants to merge 1 commit intodevfrom
Open
fix: consider kv cache 64 align to estimate kv cache memory size#417rebel-wonsubkim wants to merge 1 commit intodevfrom
rebel-wonsubkim wants to merge 1 commit intodevfrom
Conversation
+ SHOULD consider device 64B memory align for kv cache Signed-off-by: wonsub kim <subang0@rebellions.ai>
rebel-wonsubkim
changed the title
rebel-wonsubkim
requested review from
rebel-jaehwang,
rebel-jiwoopark and
rebel-ykchoi
rebel-jaehwang
approved these changes
Mar 3, 2026
Collaborator
|
@rebel-wonsubkim If there are no problems, we can go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem - in opt model test, kv cache oom occurred
Solution - when calculating kv cache available memory, SHOULD consider device kv cache 64 memory align
if head_size is not aligned to 64 (=128B), SHOULD adjust available memory for kv cache