Open
Conversation
rebel-eunji
reviewed
Mar 26, 2026
| def show_stats(self, stat_type: str): | ||
| stats = self.gen_stats(stat_type) | ||
| logger.info(stats) | ||
| if envs.VLLM_RBLN_DUMP_METRICS: |
Collaborator
There was a problem hiding this comment.
Is VLLM_RBLN_DUMP_METRICS registerd in rbln_envs.py?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of. Changes
Adding stat dump function
This pull request adds a function of dumping a file named {stat_type}_metrics.txt while printing stat metrics to stdout.
For example, in case of prefill, it will be prefill_metrics.txt.
Related Tickets
How to test
Checklist
The PR will only be reviewed and considered for merge if the following are satisfied.