fix(model): replace INVALID_TOKEN sentinel with real first-token decode in prefill for whisper models#593
Open
rebel-eunji wants to merge 6 commits intodevfrom
Open
fix(model): replace INVALID_TOKEN sentinel with real first-token decode in prefill for whisper models#593rebel-eunji wants to merge 6 commits intodevfrom
rebel-eunji wants to merge 6 commits intodevfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary of Changes
Problem
When running whisper models through vLLM serve , and a client POSTs to /v1/audio/transcriptions, vLLM raises the following error:
Solution
Replace the
INVALID_TOKENsentinel trick in Whisper prefill: now run the encoder and the first decoder step withdecoder_start_token_idto return real first-token logits to the sampler.📌 Related Issues / Tickets
✅ Type of Change
release)feature)model)core)fix)perf)refactor)docs)other): please describe🧪 How to Test
.........📸 Screenshots / Logs (if applicable)
📋 Checklist
💬 Notes