Conversation
hadley
changed the title
t-kalinowski
reviewed
Jun 8, 2026
| } | ||
| generics <- list(list(generic = generic, package = NA_character_)) | ||
| } else { | ||
| generics <- attached_generics() |
Member
There was a problem hiding this comment.
Should we also discover generics in loaded but not attached namespaces?
Member
Author
There was a problem hiding this comment.
My gut feeling is no? But that's a not particularly strongly held opinion.
lawremi
approved these changes
Jun 14, 2026
lawremi
left a comment
lawremi
left a comment
Collaborator
There was a problem hiding this comment.
The returned data.frame makes sense to me; it's what I had imagined, as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335. Fixes #435
For the first round of review I think it would be most useful to get feedback on the interface, especially the data frame that
S7_methods()returns.