Improve construction of subclasses#694
Open
hadley wants to merge 2 commits into
Open
Conversation
* `constructor_args()` no longer drops child properties that shadow parent properties, so they become constructor args with the child's default. Fixes #467. * The generated body no longer passes declared properties to the parent constructor; they go to `new_object()` instead, which runs the child's setter and class check. Fixes #585. * Read-only properties are removed from the constructor. * Constructors for subclasses of abstract classes now include parent properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constructor_args()no longer drops child properties that shadow parent properties, so they become constructor args with the child's default. Fixes Default value introduced in subclass does not propagate to constructor #467.new_object()instead, which runs the child's setter and class check. Fixes Child class property setters that mask parent class properties are unused at construction #585.