Dependency bump and CI fix - #46
Open
ptgolden wants to merge 2 commits into
Open
Conversation
The requirements being pulled in by the CI pipelines were not the same as the ones installed by users in `pyproject.toml`. This commit relaxes the range for `pybind11` and `rdflib` in `Pipefile`. The Pipfile.lock is regenerated for the new dependencies-- it doesn't seem like it had been fully regenerated since cca16cf, under Python 3.7.
`--user` is not a valid flag in a virtual environment, which is how `pipenv` runs things. The previous command also installed `build` (a build tool from PyPI) rather than `.` (this project). This now uses `pipenv run pip install` in both the test and docs build workflows.
Contributor
Author
|
This is a first step-- I was going to submit a followup patch after this to fix the PyPI release workflow. It's a little more involved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets testing and GH pages CI/CD working again by bumping dependencies and fixing package setup invocations.