[WIP] Add adapter for CrateDB - #106
Draft
amotl wants to merge 4 commits into
Draft
Conversation
It is not suitable for merging into mainline, because it modifies the data model inappropriately for other databases. The missing details would need to be put into the dialect somehow, to make it compatible with a vanilla SQLAlchemy application. C'est la vie. The patch includes a few monkeypatches and polyfills, which should be upstreamed to crate-python and/or cratedb-toolkit.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Mark,
this patch adds support for CrateDB as a database backend. It also provides an SQLAlchemy adapter, but it needed some patches to make it work and satisfy the test suite.
It is clear that the patch will never get merged as-is, but still we wanted to share it with the community here. If we can't make it better, the PR can be closed again.
With kind regards,
Andreas.