Update ZenLib #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataulien
reviewed
Apr 20, 2019
README.md
Outdated
| @@ -15,6 +15,8 @@ Most modern Linux distros provide a way to install them via the native package | |||
| manager. Ubuntu 18.04+ is known to ship recent enough versions, older distros do not | |||
| and installing from source may be necessary. | |||
|
|
|||
| On Windows, just double-click on `build.bat`. It will manage everything automatically. | |||
|
|
|||
| Dependencies on Windows are best managed using [vcpkg](https://github.com/Microsoft/vcpkg), you can | |||
| find instructions on how to build it on the official repository. Once vcpkg is installed, you should | |||
| install the following packages `physfs glm libsquish` by running | |||
There was a problem hiding this comment.
Wait, do we actually still depend on glm? That was a dependency of REGoth, but I got rid of it in ZenLib, or so I thought.
There was a problem hiding this comment.
Oh really? Then we might not need it anymore... I should probably update the ZenLib cmake
|
It is, but vcpkg is not yet integrated into REGoth-bs. I think @frabert is busy with his thesis. |
|
Yes, sorry for the absence! Once we have stable prebuilt binaries for the bs::f version that has working RTTI it should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use vcpkg to resolve dependencies