Use SHA-256 instead of SHA3-256 for record hashing#250
Open
darnjo wants to merge 49 commits into
Open
Conversation
…ed paths to variations
Update referenced version to v2.0.0
Electron bundles BoringSSL which does not support SHA3 algorithms. This causes createHash to throw when running cert-utils inside the RESO Desktop Client. SHA-256 is equally suitable for dedup hashing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When throwOnError is true, schema validation errors and other fatal conditions throw an Error instead of calling process.exit(). This allows the SDK and Electron desktop client to catch failures and handle them gracefully without killing the process. The thrown error for schema validation includes the full schemaValidationResults on the error object for programmatic access. Default is false, preserving existing CLI behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Electron bundles BoringSSL (Google OpenSSL fork), which does not support SHA3 algorithms. This causes createHash to throw Digest method not supported when running cert-utils inside the RESO Desktop Client.
SHA-256 is equally suitable for deduplication hashing -- the values are session-local and not persisted or compared across environments.
Test plan