#12: Reference Server MariaDB Initial Release #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickcoca
force-pushed
the
26-reference-server-initial-release
branch
from
310b9cd to
850e063
Compare
darnjo
changed the title
darnjo
reviewed
Mar 25, 2025
darnjo
requested changes
Mar 25, 2025
|
|
||
| ## ENVIRNONMENT SPECIFIC NOTES | ||
|
|
||
| The build scripts were moved to take place in a Docker container so that they would work consistently across environments. | ||
|
|
||
| ### Windows | ||
|
|
||
| In Windows, running under a Bash shell will work, assuming you meet the above requirements. | ||
| Don't forget to have Docker installed for Windows. | ||
|
|
||
| There is an `env-default-windows` file you should rename to `.env` before running the build script. | ||
|
|
||
| The `docker/docker-builder` file has a line commented out for Windows users, and a line that needs to be commented out. | ||
|
|
There was a problem hiding this comment.
TODO: @patrickcoca - need to add Mac build instructions and Linux if they're different. Sometimes ARM64 builds are different from AMD64 depending on which version of Linux is being used under the hood. Debian Bullseye seems to work OK.
| @@ -1,11 +1,18 @@ | |||
| FROM ubuntu:20.10 | |||
| FROM ubuntu:20.04 | |||
There was a problem hiding this comment.
@patrickcoca - may want to take a look at this Docker Compose file and migrate from Ubuntu to Debian. https://github.com/RESOStandards/reso-certification-utils/blob/main/DockerfileBullseye
src/main/java/org/reso/service/data/meta/MySQLFilterExpressionVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/reso/service/data/meta/MySQLFilterExpressionVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/reso/service/edmprovider/RESOedmProvider.java
Outdated
Show resolved
Hide resolved
…release-fixes Fixes and code cleaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12.