ci: create GitHub Release after both registries and repair missing assets

Author: eitsupi

.github/scripts/marketplace-pre-release-history.test.js

@@ -357,6 +357,19 @@ function splitJobs(options) {
     }));
 }
 
+test('split jobs: re-running only the failed registry job completes the publication', async () => {
+    const prior = run(820, '2026-10-05', 'sha-a');
+    const current = run(821, '2026-10-06', 'sha-a');
+    const firstAttempt = splitJobs({ openVsxConclusion: 'failure' });
+    const retriedOpenVsx = { ...splitJobs()[1], run_attempt: 2 };
+    const jobs = [...firstAttempt, retriedOpenVsx];
+    assert.equal(completedBothRegistries(firstAttempt), false);
+    assert.equal(completedBothRegistries(jobs), true);
+    assert.deepEqual(await decide(current, [prior, current], new Map([['820', jobs]])), {
+        publish: false, date: '2026-10-06', reason: 'unchanged',
+    });
+});
+
 for (const [format, jobsFor] of [['split jobs', splitJobs], ['old combined job', (options) => [publishJob(options)]]]) {
     test(`${format}: both registries succeeded suppress unchanged SHA`, async () => {
         const prior = run(800, '2026-10-05', 'sha-a');

.github/workflows/release.yml

@@ -34,7 +34,10 @@ jobs:
     name: Release
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    needs: verify
+    # Create the GitHub Release only after both registries have the version.
+    needs:
+      - publish-vs-marketplace
+      - publish-open-vsx
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -51,13 +54,15 @@ jobs:
           VERSION=${GITHUB_REF#refs/tags/v}
           mv artifacts/vscode-R.vsix "artifacts/r-$VERSION.vsix"
           if gh release view "v$VERSION" >/dev/null 2>&1; then
-            echo "Release v$VERSION already exists; skipping creation."
-            exit 0
+            # A previous attempt may have created the release without the asset.
+            echo "Release v$VERSION already exists; uploading the VSIX."
+            gh release upload "v$VERSION" "artifacts/r-$VERSION.vsix" --clobber
+          else
+            gh release create "v$VERSION" "artifacts/r-$VERSION.vsix" \
+              --title "v$VERSION" \
+              --notes "Release v$VERSION" \
+              --generate-notes
           fi
-          gh release create "v$VERSION" "artifacts/r-$VERSION.vsix" \
-            --title "v$VERSION" \
-            --notes "Release v$VERSION" \
-            --generate-notes
 
   publish-vs-marketplace:
     name: Publish to Visual Studio Marketplace