Skip to content

Bump sea-orm to 1.1.19 and change async runtime to tokio#67

Merged
zoedberg merged 1 commit intoRGB-Tools:masterfrom
dcorral:bump-sea-orm-tokio-runtime
Feb 27, 2026
Merged

Bump sea-orm to 1.1.19 and change async runtime to tokio#67
zoedberg merged 1 commit intoRGB-Tools:masterfrom
dcorral:bump-sea-orm-tokio-runtime

Conversation

@dcorral
Copy link
Contributor

@dcorral dcorral commented Jan 26, 2026

This PR bumps sea-orm version from 1.1.12 to 1.1.19 and also changes async runtime from async-std (deprecated) to tokio

Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete, all sea-orm crates should be bumped, entity files should be regenerated as explained in https://github.com/RGB-Tools/rgb-lib/blob/master/migration/README.md and the async runtime should be changed also in the migration crate.

Anyway, currently rgb-lib is under massive changes, which involved also the bump of sea-orm. I will update you when you can rebase this PR.

Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the tokio features if actually unneeded, address the suggested changes and then rebase on top of the latest master tip keeping a single signed commit.

@dcorral dcorral force-pushed the bump-sea-orm-tokio-runtime branch 2 times, most recently from 294237b to 3384536 Compare February 26, 2026 13:51
@dcorral
Copy link
Contributor Author

dcorral commented Feb 26, 2026

@zoedberg thanks for the review, all comments have been addressed and the branch is up to date with master. Please double check.

Let me know if there is any other change required. 🙏

Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcorral please check the requested changes and fix the formatting and lint

@dcorral dcorral force-pushed the bump-sea-orm-tokio-runtime branch from 3384536 to eed5248 Compare February 27, 2026 10:10
Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some messy imports, please check the requested changes. Also the lint job is failing because you didn't generate the lock files for the bindings, run (cd ./bindings/c-ffi && cargo clippy) and (cd ./bindings/uniffi && cargo clippy) to fix those please

@dcorral dcorral force-pushed the bump-sea-orm-tokio-runtime branch from eed5248 to 4437917 Compare February 27, 2026 10:41
Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks

@zoedberg zoedberg merged commit 5e7fc85 into RGB-Tools:master Feb 27, 2026
26 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants