add support for RGB zero asset amount invoices#101
Merged
zoedberg merged 1 commit intoRGB-Tools:masterfrom Mar 2, 2026
Merged
Conversation
nicbus
requested changes
Feb 26, 2026
nicbus
changed the title
bitwalt
force-pushed
the
rgb-zero-amount-sendpayment-fix
branch
from
1866139 to
3cf7a3d
Compare
Contributor
Author
|
Thanks for the review, suggested changes has been addressed |
bitwalt
force-pushed
the
rgb-zero-amount-sendpayment-fix
branch
from
3cf7a3d to
571728f
Compare
Contributor
Author
|
Ok requested changes should be addressed now, let me know if its okay or some more cases are needed in the test. I included the case with asset_id and asset_amount both set to None that was missing |
zoedberg
requested changes
Mar 2, 2026
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
Thanks, LGTM except for the requested change. Please also rebase the PR on the updated master
| ))); | ||
| } | ||
| } | ||
| let rgb_amount = payload.asset_amount.ok_or(APIError::IncompleteRGBInfo)?; |
Member
There was a problem hiding this comment.
please update the IncompleteRGBInfo message from For an RGB operation both asset_id and asset_amount must be set to a more generic For an RGB operation both the asset ID and amount are necessary
bitwalt
force-pushed
the
rgb-zero-amount-sendpayment-fix
branch
from
571728f to
86cd708
Compare
Contributor
Author
|
Rebased on updated master and updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reproduce #100 and provide a fix for it