expired inbound payments stuck as Pending: test and fix#99
Merged
zoedberg merged 2 commits intoRGB-Tools:masterfrom Mar 2, 2026
Merged
expired inbound payments stuck as Pending: test and fix#99zoedberg merged 2 commits intoRGB-Tools:masterfrom
zoedberg merged 2 commits intoRGB-Tools:masterfrom
Conversation
nicbus
requested changes
Feb 25, 2026
Member
nicbus
left a comment
nicbus
left a comment
There was a problem hiding this comment.
Please look for a test where this can be integrated, in order to avoid the cost of setting up a new one.
Also, please add the fix (as you proposed in #98 (comment)) on top of this commit.
bitwalt
force-pushed
the
inbound-expired-payments-test
branch
from
776d09c to
d00bea4
Compare
nicbus
requested changes
Feb 26, 2026
Member
nicbus
left a comment
nicbus
left a comment
There was a problem hiding this comment.
a few more changes
please also update the openapi spec
bitwalt
force-pushed
the
inbound-expired-payments-test
branch
from
d00bea4 to
97fa6d4
Compare
Contributor
Author
|
suggestions should have been addressed, changed the openapi in the other PR, do we need to change something also here? |
zoedberg
changed the title
nicbus
requested changes
Feb 26, 2026
Member
nicbus
left a comment
nicbus
left a comment
There was a problem hiding this comment.
thanks, a few more details to address
please also rebase on top of the updated master
Member
yes, since this PR adds |
bitwalt
force-pushed
the
inbound-expired-payments-test
branch
from
97fa6d4 to
3aa646d
Compare
Member
|
Merging this, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR add a test to reproduce #98