Windows compatability #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2024 16:05
Unsure which changes are truly required.
Exports, includes, et.c.
erikhlarsson
commented
Nov 12, 2024
| @@ -64,6 +64,7 @@ void ISO22133::State::handleEvent(TestObject& obj, const ISO22133::Events::Event | |||
| obj.state = obj.createUnknown(); | |||
| break; | |||
| } | |||
| lock.unlock(); | |||
There was a problem hiding this comment.
unsure why this was required here but not in the other locations scoped_lock was replaced
erikhlarsson
commented
Nov 12, 2024
| @@ -0,0 +1,4 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
workaround for intellisense bug
erikhlarsson
commented
Nov 12, 2024
| @@ -19,7 +19,7 @@ | |||
| %rename(LessThan) operator<(const Transition &lhs, const Transition &rhs); | |||
|
|
|||
| %typemap(in) (char *buffer, int bufferLen) { | |||
| Py_ssize_t len; | |||
| Py_size_t len; | |||
There was a problem hiding this comment.
this file was probably not meant to be changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made on iso object for windows portability & c++14, probably could use some clean-up.