makefiles/riotgen: fix colors and behavior for undefined generate-* targets
#21448
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crasbe
added
Type: bug
github-actions
bot
added
Area: build system
When executing `make generate-Makefile.ci` in the base directory, the make system would try to call `riotgen` with `Makefile.ci`, which does not work. Likewise with any other target like `make generate-bogus`. The pattern rule for the prerequisites was not evaluated by make, therefore the check did not work as intended.
crasbe
added
the
Impact: minor
mguetschow
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Recently I noticed that when you call
make generate-Makefile.cifrom the base directory, it would try to callriotgen Makefile.ci, which obviously fails. Likewise with any othergenerate-*target. Also, the colors for the warnings did not work for the warning whenriotgenis not installed:With this PR, the unrecognized target will be called out by the
Welcome Messageand the colors work for the warning. Also I made the warning a bit nicer.Testing procedure
Run
make generate-bogusandmake generate-Makefile.ciin the base directory and observe that the correct warning is displayed.Uninstall
riotgenand see that the warning is colored.Install
riotgenagain and see thatmake generate-testwill still callriotgenand ask you for the application name.