Skip to content

feat: subcategory feature#494

Merged
theperu merged 2 commits into
RIP-Comm:mainfrom
lucaantonelli:subcategory-impl
Jan 21, 2026
Merged

feat: subcategory feature#494
theperu merged 2 commits into
RIP-Comm:mainfrom
lucaantonelli:subcategory-impl

Conversation

@lucaantonelli

Copy link
Copy Markdown
Collaborator

🎯 Description

Working implementation of subcategory feature!

Closes: #198

📱 Changes

  • Subcategories are shown as a list on each category page (following figma)
  • Subcategories creation/editing page (only allow to choose name and icon, not color, since is the same of the parent category)
  • Subcategories can be selected in transactions. Click on a category with subcategories, and it will shows with an animated list the subcategory, if you don't choose a subcategory, the parent is automatically selected
  • Subcategories doesn't appear in the main category list, but only inside the parent editing page

🧪 Testing Instructions

Test the pages mentioned in the changes.

🔍 Checklist for reviewers

  • Code is formatted correctly
  • Tests are passing
  • [] New tests are added (if needed)
  • Style matches the figma/designer requests
  • Tested on:
    • iOS
    • Android

@theperu theperu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaantonelli I noticed a few things while testing:

Screenshot 2026-01-18 at 20 11 03

@theperu theperu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaantonelli I can see that all issues are fixed but there is still something I would like to change. Now the subcategories are treated as a normal category in the transactions page and they are just pushed at the bottom which looks a bit odd to me (Video 🎥)

Screen.Recording.2026-01-19.at.20.03.07.mov

I would suggest to group them inside their main category kinda like what I did here

Screen.Recording.2026-01-19.at.20.16.59.mp4

NOTE: I won't push this code because it's vibecoded and I don't trust it 😅

@federicopozzato

Copy link
Copy Markdown
Collaborator

I like it! I think it's good

@theperu theperu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@theperu theperu merged commit 1c3ae96 into RIP-Comm:main Jan 21, 2026
1 check passed
@lucaantonelli lucaantonelli deleted the subcategory-impl branch January 21, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Subcategories

3 participants