FWT-146 Solve Dat One (SDO) Issue#112
Merged
Merged
Conversation
…re/diegolhendrix/sdo-sample
…re/diegolhendrix/sdo-sample
DiegoLHendrix
changed the title
…re/diegolhendrix/sdo-sample
…re/diegolhendrix/sdo-sample
mjh9585
requested changes
Dec 14, 2024
mjh9585
left a comment
mjh9585
left a comment
Contributor
There was a problem hiding this comment.
Just a few changes, mostly should make a method to register a callback that is used by the sdo.
mjmagee991
requested changes
Jan 15, 2025
mjh9585
requested changes
Feb 22, 2025
mjh9585
left a comment
mjh9585
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of changes. Make sure to clean up leftover code from the unresolved comments.
…/RIT-EVT/EVT-core into feature/diegolhendrix/sdo-sample
mjh9585
requested changes
Mar 30, 2026
mjh9585
left a comment
mjh9585
left a comment
Contributor
There was a problem hiding this comment.
Overall pretty good, just needs a few changes and a little polish. Also you never take advantage of your blocking methods in your sample which could be helpful to see an example for simple use cases.
aclowmclaughlin
approved these changes
Apr 13, 2026
aclowmclaughlin
left a comment
aclowmclaughlin
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Minor stuff and obviously you're going to need to test it.
Approving, pending a demonstrated test setup working.
…ontext and updated callback function names
mjh9585
approved these changes
Apr 21, 2026
mjh9585
left a comment
mjh9585
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just need some formatting fixes,
DiegoLHendrix
changed the title
DiegoLHendrix
changed the title
…/RIT-EVT/EVT-core into feature/diegolhendrix/sdo-sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.