feat(recalls): Phase E — recall / follow-up dashboard

[RJK134]

Summary

Phase E of docs/UAT_v2_DELIVERY_PLAN.md — adds the recall / follow-up dashboard, closing UAT-CLN-04 (the most-promised UAT P0 gap) and defect D-3 from docs/UAT_v2_VALIDATION.md.

The backend was already there — every horse carries dentalDueDate + vaccinationDueDate and lib/services/reminder.service.ts already dispatches reminders against them. This PR surfaces an operator UI to see what's due.

Changes

File	What
app/api/recalls/route.ts (new)	GET /api/recalls with ?yardId= filter; returns { rows, buckets }. RBAC: requireRole(READONLY). Joins prisma.auditLog for last reminder per (horse, type).
app/[locale]/recalls/page.tsx (new)	Three-tab UI (Overdue / Due 30d / Due 30–90d), rows grouped by yard, links to horse detail, shows last-reminder relative time.
app/api/dashboard/route.ts	Adds pendingRecallsCount to stats. Single Prisma horse.count for horses due within 90 days.
app/[locale]/dashboard/page.tsx	New tile "Pending Recalls" linking to /recalls. Grid widened to lg:grid-cols-5.
components/layout/Sidebar.tsx	Adds "Recalls" entry between Planning and Visit Requests.
messages/{en,fr}.json	Full recalls.* namespace + nav.recalls + dashboard.pendingRecalls. EN/FR parity.
__tests__/unit/api/recalls.test.ts (new)	4 cases: bucketing, per-type row emission, last-reminder dedup, yardId filter.
__tests__/unit/api/dashboard.test.ts	Adds prisma.horse.count to mock so the existing dashboard test still passes.

What it looks like

• Operator opens /en/recalls → sees three tabs with badge counts.
• Default tab is Overdue (most actionable).
• Each row: horse name → links to horse detail; owner name; recall type (Dental/Vaccination); days-overdue badge; due date; "Reminded 3 days ago" label if a reminder was already dispatched.
• Empty state when nothing matches the tab.
• Mobile-first: tabs scroll horizontally on narrow viewports; rows stack vertically below sm.

Test plan

• CI five-check gate passes (lint + typecheck + prisma validate + test + build).
• Vercel preview renders /en/recalls and /fr/recalls cleanly.
• Operator walks 390px Safari: tabs work, yard grouping renders, links navigate.
• Dashboard tile "Pending Recalls" shows a count and links to /recalls.

Local five-check gate skipped: sandbox has no node_modules and global Prisma CLI is v7 (repo uses v6). CI on this PR runs the full gate on a fresh runner.

Stop-gate

Final merge belongs to Richard or Freddie. UAT-CLN-04 verdict in docs/UAT_v2_VALIDATION.md flips FAIL → PASS once merged.

Phase D linkage

Closed	Status
UAT-CLN-04 (recall list / dashboard)	✅ this PR
D-3 from validation report	✅ this PR
D-2 (prod has 0 invoices)	⏳ awaiting GH Actions seed-demo-database run on main
D-4 (login broken report)	✅ closed by operator confirmation

https://claude.ai/code/session_01JBMfnqc8QXZRqCG3Tm7hHx

---

Generated by Claude Code

---

Note

Medium Risk
Adds a new RBAC-protected API endpoint with Prisma queries over horse and auditLog, plus new UI/navigation surfaces that depend on the new data shape; main risk is correctness/performance of due-date filtering and reminder aggregation.

Overview
Introduces a recalls dashboard: a new /recalls page that fetches GET /api/recalls, shows three tabs (overdue / due in 30 / due in 30–90), groups rows by yard, and displays due date plus the most recent reminder timestamp per horse+type.

Adds GET /api/recalls (READONLY) that returns { rows, buckets } by selecting active, non-deleted horses with dental/vaccination due within 90 days, optionally filtering by ?yardId=, and joining auditLog to attach the latest reminder per recall type.

Extends the main dashboard to include pendingRecallsCount (computed via prisma.horse.count) and a new summary tile linking to /recalls, adds a sidebar nav entry, updates EN/FR i18n strings, and adds unit tests covering bucketing, per-type row emission, reminder de-duping, and yard filtering.

^{Reviewed by Cursor Bugbot for commit 519908a. Configure here.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
equismile	Error		May 8, 2026 0:48am

[Copilot]

Pull request overview

Adds “Recalls / Follow-ups” operator visibility for horses with dental/vaccination due dates, leveraging existing due-date fields + reminder dispatching, and surfaces a headline metric on the main dashboard.

Changes:

• Introduces GET /api/recalls plus a new /[locale]/recalls UI with bucketing (overdue / due in 30 / due in 30–90) and yard grouping.
• Adds pendingRecallsCount to /api/dashboard and a new “Pending Recalls” tile linking to /recalls.
• Updates navigation + EN/FR message catalogs, and adds/updates unit tests for the new API + dashboard mock.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
app/api/recalls/route.ts	New recalls API endpoint returning rows + bucket counts, with audit-log join for last reminder.
app/[locale]/recalls/page.tsx	New client page showing tabbed recall buckets, grouped by yard, linking to horse detail.
app/api/dashboard/route.ts	Adds pendingRecallsCount to dashboard stats via a Prisma count query.
app/[locale]/dashboard/page.tsx	Adds a new summary card for pending recalls and widens the grid to 5 columns.
components/layout/Sidebar.tsx	Adds “Recalls” to the primary nav list.
messages/en.json	Adds nav.recalls, dashboard.pendingRecalls, and recalls.* strings.
messages/fr.json	Adds FR equivalents for nav.recalls, dashboard.pendingRecalls, and recalls.*.
__tests__/unit/api/recalls.test.ts	New unit tests for bucketing, per-type emission, reminder deduping, and yard filtering.
__tests__/unit/api/dashboard.test.ts	Extends Prisma mock to include horse.count so dashboard tests still pass.

[RJK134]

@copilot apply changes based on this feedback

[RJK134]

Already applied in commit c1413a9 — format.relativeTime(new Date(row.lastReminderSentAt)) is back, rendering as "Reminded 3 days ago" per the PR description. (I'd swapped to dateTime in 519908a while guessing at the cause of the failing build; turned out the real bug was unrelated LoadingState/EmptyState props, so relativeTime is safe to use again.) Safe to resolve.

---

Generated by Claude Code

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Skip-to-content link target ID mismatch breaks accessibility
  • Changed the recalls page <main> element from id="main" to id="main-content" so it matches SkipToContent's #main-content href.
• ✅ Fixed: DUE_30 badge uses wrong variant, ignoring warning tone
  • Row badges now map each bucket to danger, warning, or info so DUE_30 rows use the warning variant like the tabs.

Or push these changes by commenting:

@cursor push d0711b633b

Preview (d0711b633b)

diff --git a/app/[locale]/recalls/page.tsx b/app/[locale]/recalls/page.tsx
--- a/app/[locale]/recalls/page.tsx
+++ b/app/[locale]/recalls/page.tsx
@@ -95,7 +95,7 @@
       <Header />
       <div className="flex">
         <Sidebar />
-        <main id="main" className="flex-1 px-4 py-6 lg:px-8">
+        <main id="main-content" className="flex-1 px-4 py-6 lg:px-8">
           <PageHeader title={t('title')} subtitle={t('subtitle')} />
 
           {loading && <LoadingState />}
@@ -159,7 +159,15 @@
                               </span>
                             </div>
                             <div className="flex items-center gap-2">
-                              <Badge variant={row.bucket === 'OVERDUE' ? 'danger' : 'info'}>
+                              <Badge
+                                variant={
+                                  row.bucket === 'OVERDUE'
+                                    ? 'danger'
+                                    : row.bucket === 'DUE_30'
+                                      ? 'warning'
+                                      : 'info'
+                                }
+                              >
                                 {row.daysOffset < 0
                                   ? t('daysOverdue', { count: Math.abs(row.daysOffset) })
                                   : t('daysUntil', { count: row.daysOffset })}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 519908a. Configure here.}

[cursor]

Skip-to-content link target ID mismatch breaks accessibility

Medium Severity

The SkipToContent component renders a link to #main-content, but this page's <main> element uses id="main" instead of id="main-content". Every other page that includes SkipToContent (dashboard, observability, demo) correctly uses id="main-content". Keyboard and screen-reader users who activate the skip link on the recalls page won't be navigated to the content area.

 

^{Reviewed by Cursor Bugbot for commit 519908a. Configure here.}

[RJK134]

@claude please fix above

[RJK134]

Already fixed in commit c1413a9 — the <main> id is now main-content, matching the dashboard / observability / demo pages and the SkipToContent link target. Verified against the current feature/recall-dashboard HEAD:

<main id="main-content" className="flex-1 px-4 py-6 lg:px-8">

GitHub flagged this thread as outdated because the line numbers shifted under the rewrite, but the fix itself is in the branch. Safe to resolve.

---

Generated by Claude Code

[cursor]

DUE_30 badge uses wrong variant, ignoring warning tone

Low Severity

The row Badge only distinguishes OVERDUE (danger) from all other buckets (info), but the tab structure explicitly defines three urgency tones: danger for overdue, warning for due-in-30, and info for due-in-30-to-90. Items in the DUE_30 bucket display with a blue info badge instead of the expected amber warning badge, visually downplaying their relative urgency and creating inconsistency with the tab styling.

 

^{Reviewed by Cursor Bugbot for commit 519908a. Configure here.}

[RJK134]

@claude please resolve and fix

[RJK134]

Already fixed in commit c1413a9. Row badge variant now distinguishes three tones to match the tab styling:

<Badge
  variant={
    row.bucket === 'OVERDUE' ? 'danger' :
    row.bucket === 'DUE_30'  ? 'warning' :
                               'info'
  }
>

GitHub flagged this thread as outdated because the line numbers shifted under the rewrite. Safe to resolve.

---

Generated by Claude Code

[RJK134]

@cursor push d0711b6