Phase 46: intake→completion e2e test (KI-016 O, demo spine) + CI Postgres job

[RJK134]

Phase 46 — KI-016 O: full intake→completion e2e ("demo spine")

The long-deferred KI-016 O. The investigation confirmed the pipeline is already fully wired (zero product-code changes needed), so this is a test + CI-infra + docs deliverable that proves the whole spine connects under real data and keeps it from regressing.

What it does

__tests__/e2e/intake-to-completion.test.ts drives the real domain services (no Prisma/env mocks) against a freshly-migrated Postgres, asserting every status hand-off across the pipeline:

intake (processWhatsAppPayload) → auto-triage → route proposal → vet approval → booking → confirmation → completion → follow-up regeneration

with exact transition assertions at each seam (PLANNING_POOL → CLUSTERED → APPROVED → BOOKED, Appointment PROPOSED → CONFIRMED → COMPLETED, ConfirmationDispatch audit row, AppointmentStatusHistory rows, and the regenerated FOLLOW_UP VisitRequest back in PLANNING_POOL). A second test covers the URGENT → automationHold exclusion path (held out of all proposals until a vet clears it). Self-contained e2e- fixtures with child-first cleanup → idempotent.

How it runs (the one sensitive change — please eyeball the CI diff)

• New isolated vitest.e2e.config.ts (includes only __tests__/e2e/**); the default vitest.config.ts now excludes that dir, so the 2,835-test unit suite never touches a real DB. Script npm run test:e2e.
• Gated by RUN_DB_E2E — without it the suite skips, so local npm run test and any non-DB runner stay green.
• CI: additive e2e job in .github/workflows/ci.yml — needs: check, a postgres:16 service container, prisma migrate deploy, then npm run test:e2e. It does not touch the existing check/docker/security gates (action SHAs match them). It adds a new check (~1–2 min + a Postgres spin-up) on PRs.

Findings (the real prize)

No integration bug — the spine is correct. Three inaccuracies in the original map were corrected in the test (real product behaviour): the VisitRequest ends route-proposal at CLUSTERED (there is no PROPOSED planningStatus; PROPOSED is an Appointment status); bookRouteRun hard-requires RouteRun.status === 'APPROVED', i.e. there's a genuine vet-approval gate before booking; and a lone yard only yields a proposal at ≥3 horses (clustering threshold).

One genuine deferred gap logged as KI-031: confirmation.service.ts shouldUseTemplate() only does the 24h-window check in demo mode (TODO(prod)) — Meta-gated, harmless until live WhatsApp, but a real loose end to wire when Meta verification lands.

Verification (independently re-run on this branch)

• npm run test:e2e → 2 passed against real Postgres; re-run idempotent (zero e2e- residue).
• npm run test → 279 files / 2,835 passed, e2e dir excluded. lint ✓ typecheck ✓ prisma validate ✓ build ✓.

Docs: docs/PHASE_46_KI_016_O_DEMO_WALKTHROUGH.md (rehearsed UI demo script + the 3 intentional vet gates); KNOWN_ISSUES updated (KI-016 O delivered, KI-031 added). No schema change, no migration.

Final merge left to Richard / Freddie.

https://claude.ai/code/session_01VzJJTUcvzZgS9jN8aap9iv

---

Generated by Claude Code

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
34021120	Triggered	Generic Password	f95bd40	.github/workflows/ci.yml	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b299f61. Configure here.}

[cursor]

CI paths skip e2e tests

Medium Severity

The new e2e job only runs when the check job runs, but pull_request uses a paths filter that omits __tests__/**, vitest.config.ts, and vitest.e2e.config.ts. PRs that change only the real-database e2e suite (or Vitest split) skip the whole workflow, so the demo-spine test never runs in review despite the PR promising CI coverage.

 

^{Reviewed by Cursor Bugbot for commit b299f61. Configure here.}

[RJK134]

Superseded by #263 — identical content, rebuilt as a single clean commit so no intermediate commit carries the ephemeral CI Postgres password GitGuardian flagged (it was never a real secret — a throwaway service-container password). The real gates here were all green (check, the new e2e Postgres job, docker, security); #263 carries the same verified content plus the Bugbot paths:-filter fix. Closing in favour of #263.

---

Generated by Claude Code