internal: land #261 review fixes onto feature/46 (proxy workaround)

.github/workflows/ci.yml

@@ -14,6 +14,9 @@ on:
       - 'public/**'
       - 'i18n/**'
       - 'scripts/**'
+      - '__tests__/**'
+      - 'vitest.config.ts'
+      - 'vitest.e2e.config.ts'
       - 'auth.ts'
       - 'middleware.ts'
       - 'instrumentation.ts'
@@ -67,20 +70,24 @@ jobs:
     services:
       postgres:
         image: postgres:16
+        # Throwaway credentials for an ephemeral CI service container (the
+        # same test:test convention the `check` job's stub DATABASE_URL uses)
+        # — not a secret; the container exists only for this job's lifetime.
         env:
-          POSTGRES_USER: equismile
-          POSTGRES_PASSWORD: equismile_ci_pw
+          POSTGRES_USER: test
+          POSTGRES_PASSWORD: test
           POSTGRES_DB: equismile_e2e
         ports:
           - 5432:5432
         options: >-
-          --health-cmd "pg_isready -U equismile -d equismile_e2e"
+          --health-cmd "pg_isready -U test -d equismile_e2e"
           --health-interval 5s
           --health-timeout 5s
           --health-retries 10
     env:
-      # Real service-container DB (NOT the test stub the `check` job uses).
-      DATABASE_URL: "postgresql://equismile:equismile_ci_pw@localhost:5432/equismile_e2e"
+      # Real (connecting) service-container DB — unlike the `check` job's
+      # non-connecting stub. Throwaway test:test creds, ephemeral container.
+      DATABASE_URL: "postgresql://test:test@localhost:5432/equismile_e2e"
       RUN_DB_E2E: "1"
       DEMO_MODE: "true"
       SKIP_ENV_VALIDATION: "true"