internal: land #271 refund row-lock fix (proxy workaround)#272
Merged
Conversation
…efund Cursor review on #271: refundService.issue validated amount against sum(payments) - sum(refunds) inside a read-committed transaction without locking, so two overlapping requests could each see the same prior-refund total and both commit, refunding beyond money received. Take a 'SELECT 1 FROM "Invoice" WHERE id = ? FOR UPDATE' row lock at the top of the transaction so concurrent refunds on the same invoice serialise — the ceiling read + insert are now atomic. +1 test pinning the lock. https://claude.ai/code/session_01VzJJTUcvzZgS9jN8aap9iv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal ref-move (not for review): lands the #271 Cursor fix (row-lock refunds against the concurrent over-refund race) onto the PR branch. Proxy blocks direct update-pushes; rebase-merged immediately.
https://claude.ai/code/session_01VzJJTUcvzZgS9jN8aap9iv
Generated by Claude Code