refactor(tasks): extract taskTypeLabel utility and deduplicate triage/dashboard mappings by RJK134 · Pull Request #85 · RJK134/EquiSmile

RJK134 · 2026-05-01T14:17:35Z

This pull request contains changes generated by a Cursor Cloud Agent

The dashboard's "Triage Tasks" panel was rendering raw enum values (URGENT_REVIEW, CLARIFY_SYMPTOMS, ASK_FOR_POSTCODE, ASK_HORSE_COUNT, MANUAL_CLASSIFICATION) where the triage page itself maps them through i18n via taskTypeLabel + t(). Mirrors the pattern at app/[locale]/triage/page.tsx:184–193 and 321: - Adds useTranslations('triage') as tTriage. - Adds the same taskTypeLabel(taskType) mapping. - Replaces {task.taskType} with {tTriage(taskTypeLabel(task.taskType))}. All five enum values are already keyed in messages/{en,fr}.json under the triage namespace (urgentReview, askPostcode, askHorseCount, clarifySymptoms, manualClassification). Fallback returns the raw value if the map ever drifts out of sync. Closes Finding 7 of docs/UAT_v1_1_TRIAGE_round2.md. https://claude.ai/code/session_01PF4MU4P4Ytt9UcuVsbAzT5

Both dashboard and triage pages had an identical taskTypeLabel mapping copy-pasted between them. Move it to lib/utils/task-type-label.ts so future enum or translation key changes only need to be made in one place.

vercel · 2026-05-01T14:17:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
equi-smile	Error		May 8, 2026 10:40am
equismile	Error		May 8, 2026 10:40am

Copilot

Pull request overview

This PR deduplicates the triage task-type → translation-key mapping by extracting it into a shared utility, and updates the triage + dashboard pages to use the shared helper.

Changes:

Added lib/utils/task-type-label.ts with a taskTypeLabel helper that maps TriageTaskType enum strings to triage.* translation keys.
Replaced duplicated inline mapping logic in app/[locale]/triage/page.tsx with the shared helper.
Replaced duplicated inline mapping logic in app/[locale]/dashboard/page.tsx with the shared helper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
lib/utils/task-type-label.ts	New shared helper for mapping triage task-type enums to translation keys.
app/[locale]/triage/page.tsx	Uses the shared helper instead of an inline map.
app/[locale]/dashboard/page.tsx	Uses the shared helper instead of an inline map.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-05-01T14:21:52Z

+export function taskTypeLabel(taskType: string): string {
+  const map: Record<string, string> = {
+    URGENT_REVIEW: 'urgentReview',
+    ASK_FOR_POSTCODE: 'askPostcode',
+    ASK_HORSE_COUNT: 'askHorseCount',
+    CLARIFY_SYMPTOMS: 'clarifySymptoms',
+    MANUAL_CLASSIFICATION: 'manualClassification',
+  };
+  return map[taskType] ?? taskType;
+}


taskTypeLabel returns the raw enum value for unknown task types, but consumers typically pass the result straight into useTranslations('triage'). In this repo t(...) can throw on missing keys (see StatusBadge which wraps translation in try/catch), so an unmapped/new enum value would crash instead of falling back to a visible label. Consider changing this helper (or its callers) to avoid calling t(...) for unknown types (e.g., return null/undefined for unknown, or provide a safe-translation helper that catches and falls back to the raw enum).

@copilot apply changes based on this feedback

Changed taskTypeLabel to return string | null — null for unknown task types — so callers never pass an unmapped value to t(). Both triage and dashboard pages now guard with taskLabelKey != null ? t(taskLabelKey) : task.taskType, falling back to the raw enum string instead of crashing. Commit: 47152c3.

Copilot · 2026-05-01T14:21:52Z

+export function taskTypeLabel(taskType: string): string {
+  const map: Record<string, string> = {
+    URGENT_REVIEW: 'urgentReview',
+    ASK_FOR_POSTCODE: 'askPostcode',
+    ASK_HORSE_COUNT: 'askHorseCount',
+    CLARIFY_SYMPTOMS: 'clarifySymptoms',
+    MANUAL_CLASSIFICATION: 'manualClassification',
+  };
+  return map[taskType] ?? taskType;
+}


This helper is introduced without unit tests. Most other lib/utils/* modules have Vitest coverage under __tests__/unit/utils/*; adding a small test suite for the mapping + fallback behavior would help prevent regressions when task types or translation keys change.

@copilot apply changes based on this feedback

Added __tests__/unit/utils/task-type-label.test.ts with 7 tests covering all five known mappings plus null returns for an unknown type and an empty string. Commit: 47152c3.

RJK134 · 2026-05-01T14:45:52Z

@copilot resolve the merge conflicts in this pull request

cursor · 2026-05-01T14:46:02Z

Automatically closed this PR because it was created by Bugbot autofix for #77, and that PR was closed.

RJK134 · 2026-05-01T14:50:21Z

@copilot review unmerged commits and resolve

RJK134 · 2026-05-07T23:35:53Z

@copilot apply changes based on the comments in this thread

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/RJK134/EquiSmile/sessions/9ea8e98d-e479-4ece-9130-11de6f3585a3 Co-authored-by: RJK134 <167345619+RJK134@users.noreply.github.com>

Copilot · 2026-05-07T23:42:15Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

checkpoint.prisma.io
- Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/EquiSmile/EquiSmile/node_modules/prisma/build/child {"product":"prisma","version":"6.19.3","cli_install_type":"local","information":"","local_timestamp":"2026-05-07T23:38:37Z","project_hash":"d7fc30d6","cli_path":"/home/REDACTED/work/EquiSmile/EquiSmile/node_modules/.bin/prisma","cli_path_hash":"b3daa67a","e (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ility # Conflicts: # app/[locale]/dashboard/page.tsx # app/[locale]/triage/page.tsx Co-authored-by: RJK134 <167345619+RJK134@users.noreply.github.com>

RJK134 · 2026-05-08T10:33:51Z

@copilot please resolve the merge conflicts in this pull request against the latest main. The conflicts are in app/[locale]/dashboard/page.tsx and app/[locale]/triage/page.tsx. Note: PR #119 indicates this PR is partially superseded — main now has lib/utils/triage-task-type.ts as the canonical utility (instead of lib/utils/task-type-label.ts). Please reconcile by either re-pointing imports to the canonical utility or by keeping this branch's utility consistent with main's contract. After resolving, ensure all unit tests pass.

…onical utility - Re-point dashboard and triage page imports from lib/utils/task-type-label to the canonical lib/utils/triage-task-type (landed via PR #119) - Simplify call sites to direct t(taskTypeLabel(...)) — safe because TRIAGE_TASK_TYPE_LABEL_MAP is typed against the full TriageTaskType enum, so all known values are covered; unknown values fall back to the raw string - Remove superseded lib/utils/task-type-label.ts - Rename __tests__/unit/utils/task-type-label.test.ts → __tests__/unit/utils/triage-task-type.test.ts; update import and fallback assertions to match the canonical utility's string-return contract Co-authored-by: RJK134 <167345619+RJK134@users.noreply.github.com>

Copilot · 2026-05-08T10:41:08Z

@copilot please resolve the merge conflicts in this pull request against the latest main. The conflicts are in app/[locale]/dashboard/page.tsx and app/[locale]/triage/page.tsx. Note: PR #119 indicates...

Resolved. Merged origin/main into this branch and resolved all four conflict markers in both files. The resolution adopts main's canonical utility:

Both pages now import from @/lib/utils/triage-task-type (PR Consolidate open PRs and feature branches into a single mergeable branch #119's canonical path)
Call sites simplified back to t(taskTypeLabel(...)) — safe because TRIAGE_TASK_TYPE_LABEL_MAP is typed against the full TriageTaskType enum, so all known values are covered and unknown values fall back to the raw string
lib/utils/task-type-label.ts removed (superseded)
Test file renamed to __tests__/unit/utils/triage-task-type.test.ts and updated to import from the canonical utility; fallback assertions updated from null to the raw string to match the canonical contract

All 1138 tests pass. Commit: a6c404a.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

checkpoint.prisma.io
- Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/EquiSmile/EquiSmile/node_modules/prisma/build/child {"product":"prisma","version":"6.19.3","cli_install_type":"local","information":"","local_timestamp":"2026-05-08T10:38:23Z","project_hash":"d7fc30d6","cli_path":"/home/REDACTED/work/EquiSmile/EquiSmile/node_modules/.bin/prisma","cli_path_hash":"b3daa67a","e (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/EquiSmile/EquiSmile/node_modules/prisma/build/child {"product":"prisma","version":"6.19.3","cli_install_type":"local","information":"","local_timestamp":"2026-05-08T10:38:25Z","project_hash":"d7fc30d6","cli_path":"/home/REDACTED/work/EquiSmile/EquiSmile/node_modules/.bin/prisma","cli_path_hash":"b3daa67a","e (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

claude and others added 2 commits May 1, 2026 11:54

refactor: extract taskTypeLabel into shared utility

95deafe

Both dashboard and triage pages had an identical taskTypeLabel mapping copy-pasted between them. Move it to lib/utils/task-type-label.ts so future enum or translation key changes only need to be made in one place.

Copilot AI review requested due to automatic review settings May 1, 2026 14:17

Copilot started reviewing on behalf of RJK134 May 1, 2026 14:18 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Copilot started work on behalf of RJK134 May 1, 2026 14:46 View session

Base automatically changed from fix/dashboard-tasktype-i18n to main May 1, 2026 14:46

cursor Bot closed this May 1, 2026

cursor Bot deleted the cursor/task-type-label-utility-a92e branch May 1, 2026 14:46

Copilot stopped work on behalf of RJK134 due to an error May 1, 2026 14:46
The session was cancelled by the user.

RJK134 restored the cursor/task-type-label-utility-a92e branch May 1, 2026 14:49

RJK134 reopened this May 7, 2026

RJK134 changed the title ~~PR Body End change~~ refactor(tasks): extract taskTypeLabel utility and deduplicate triage/dashboard mappings May 7, 2026

Copilot started work on behalf of RJK134 May 7, 2026 23:36 View session

Update lib/utils/task-type-label.ts

7baf104

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vercel Bot had a problem deploying to Preview May 7, 2026 23:36 Failure

fix(task-type-label): return null for unknown types and add unit tests

47152c3

Agent-Logs-Url: https://github.com/RJK134/EquiSmile/sessions/9ea8e98d-e479-4ece-9130-11de6f3585a3 Co-authored-by: RJK134 <167345619+RJK134@users.noreply.github.com>

vercel Bot had a problem deploying to Preview May 7, 2026 23:39 Failure

refactor(task-type-label): avoid double lookup in map callbacks

967e38b

Agent-Logs-Url: https://github.com/RJK134/EquiSmile/sessions/9ea8e98d-e479-4ece-9130-11de6f3585a3 Co-authored-by: RJK134 <167345619+RJK134@users.noreply.github.com>

vercel Bot had a problem deploying to Preview May 7, 2026 23:41 Failure

Copilot finished work on behalf of RJK134 May 7, 2026 23:42

Copilot AI mentioned this pull request May 8, 2026

Consolidate open PRs and feature branches into a single mergeable branch #119

Merged

Copilot started work on behalf of RJK134 May 8, 2026 10:33 View session

vercel Bot had a problem deploying to Preview May 8, 2026 10:40 Failure

Copilot finished work on behalf of RJK134 May 8, 2026 10:42

RJK134 mentioned this pull request May 8, 2026

feat(demo): LIVE_MAPS override, UAT feedback form, AUTH fixes, demo runbook updates #118

Merged

6 tasks

RJK134 merged commit 566f6ed into main May 8, 2026
5 of 6 checks passed

RJK134 deleted the cursor/task-type-label-utility-a92e branch May 8, 2026 11:34

Conversation

RJK134 commented May 1, 2026

Uh oh!

vercel Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

RJK134 May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

RJK134 May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RJK134 commented May 1, 2026

Uh oh!

cursor Bot commented May 1, 2026

Uh oh!

RJK134 commented May 1, 2026

Uh oh!

RJK134 commented May 7, 2026

Uh oh!

Copilot AI commented May 7, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

RJK134 commented May 8, 2026

Uh oh!

Copilot AI commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel Bot commented May 1, 2026 •

edited

Loading

Copilot AI commented May 8, 2026 •

edited

Loading