Skip to content

Move npm run build as part of docker build #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Move npm run build as part of docker build #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fef5112
Move `npm run build` as part of docker build
AlexAxthelm Dec 5, 2024
74a6201
Update mount path to not clobber local build
AlexAxthelm Dec 5, 2024
490d027
Add build_artifacts to gitignore
AlexAxthelm Dec 5, 2024
643ada4
Merge branch 'main' into build/128-build-in-image
AlexAxthelm Dec 6, 2024
08d28d1
Merge branch 'main' into build/128-build-in-image
AlexAxthelm Dec 9, 2024
d509d03
remove mis-named build script, and inline command in Dockerfile
AlexAxthelm Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ node_modules
.vercel
/.svelte-kit
/build
/build_artifacts
/test-results

# Data
Expand Down
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ RUN npm install \
# Copy the source code to the working directory
COPY src ./src
COPY static ./static
COPY scripts ./scripts

CMD ["./scripts/build.sh"]
# Build the application
RUN npm run build

CMD ["cp", "-rv", "/app/build/.", "/mnt/build_artifacts/"]
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ services:
# command: ["sh"]
volumes:
- type: bind
source: ${STATIC_BUILD_PATH:-./build}
source: ${STATIC_BUILD_PATH:-./build_artifacts}
target: /mnt/build_artifacts
read_only: false
network_mode: none
Expand All @@ -20,7 +20,7 @@ services:
- 3000:80
volumes:
- type: bind
source: ${STATIC_BUILD_PATH:-./build}
source: ${STATIC_BUILD_PATH:-./build_artifacts}
target: /usr/share/nginx/html
read_only: false
- type: bind
Expand Down
5 changes: 0 additions & 5 deletions scripts/build.sh
View file
Open in desktop

This file was deleted.

Loading