Skip to content

Conversation

@cjyetman
Copy link
Member

based on @jdhoffa's suggestion here #94 (comment)

not sure if this is the best way to do this

@cjyetman cjyetman requested a review from MonikaFu as a code owner December 11, 2024 11:46
@cjyetman cjyetman requested review from jdhoffa and removed request for MonikaFu December 11, 2024 11:46
@github-actions
Copy link

github-actions bot commented Dec 11, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-11 12:39 UTC

@github-actions
Copy link

github-actions bot commented Dec 11, 2024

Docker build status

commit_time git_sha image
2024-12-11T12:33:20Z f6ef423 ghcr.io/rmi-pacta/pacta-dashboard-svelte:pr-159

@jdhoffa
Copy link
Member

jdhoffa commented Dec 11, 2024

This gets us halfway there, but we will need to ensure that the tabs span the full width of the window (and the height up until the AppBar).

Currently this introduces whitespace:
Screenshot 2024-12-11 at 12 49 51

@cjyetman cjyetman marked this pull request as draft December 11, 2024 11:51
@jdhoffa
Copy link
Member

jdhoffa commented Dec 11, 2024

not sure if this is the best way to do this

It absolutely might not be 😊

@cjyetman
Copy link
Member Author

this was an experiment, which did not end well 🤣 closing

@cjyetman cjyetman closed this Dec 11, 2024
@jdhoffa jdhoffa deleted the keep-tab-bar-at-top branch December 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the tabs float on top of the page like the header bar

3 participants