Only show vol trajectory div for some sectors #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Indeed I noticed the behaviour that you noticed! But if you want to solve it with #59 that is fine. |
jdhoffa
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show volume trajectory div and fetch a plot when the chosen sector is a sector with technology pathway.
NOTE: some strange behaviour occurs when some combination of selectors is chosen but I believe it has nothing to do with this PR and is related to #59 . In some cases there is no data to fit the portfolio allocation selector and once that happens no plot that uses portfolio allocation can be drawn anymore because the value is
null. This will be solved when implementing error handling and solving the bug.